Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/etc/resolver is not respected on MacOS #632

Closed
Smirl opened this issue Feb 7, 2023 · 0 comments · Fixed by #633
Closed

/etc/resolver is not respected on MacOS #632

Smirl opened this issue Feb 7, 2023 · 0 comments · Fixed by #633
Labels

Comments

@Smirl
Copy link
Contributor

Smirl commented Feb 7, 2023

Describe the bug

Until recently, /etc/resolver/ was not respected by golang's built in DNS resolver. (background on custom resolvers)

This was recently fixed in golang 1.20. See golang/go#12524

To reproduce

  1. Create a file in /etc/resolver/myhost.com with content (can change the ip address to your custom DNS, etc):
nameserver 8.8.8.8 
  1. Run evans --host myhost.com -r cli list
  2. See that it doesn't use the custom DNS server (NXDOMAIN if the DNS resolver is required, for example).

Expected behavior

evans binaries distributed by the standard methods (brew, etc.) are built with CGO_ENABLED=0. They should respect the /etc/resolver DNS settings.

Environment

  • OS: MacOS only
  • Terminal: zsh
  • Evans version: v0.10.9
  • protoc version: N/A
  • protoc plugin version (if you are using): N/A

Additional context

I will raise a PR to:

  • upgrade to golang 1.20
  • run a go mod tidy for good measure
  • Shouldn't be an issue for most users as it doesn't matter what version of go is used to compile the binary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant