Add ability to retry runTest on backend #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it looks like server is not restarted between repeats, let me check if I can fix it |
|
This failure seems caused by the latest Tomcat update: #4470 |
|
Thanks, will check what has been changed |
osipxd
reviewed
Nov 22, 2024
| fun collectUnhandledException(error: Throwable) // TODO: better name? | ||
| fun runTest(block: suspend CoroutineScope.() -> Unit): TestResult | ||
| fun runTest(timeout: Duration, block: suspend CoroutineScope.() -> Unit): TestResult | ||
| fun runTest(timeout: Duration = 60.seconds, block: suspend CoroutineScope.() -> Unit): TestResult |
There was a problem hiding this comment.
I'm not sure about such a big default timeout. Successful tests usually run faster.
There was a problem hiding this comment.
Could you tell me if you have any value in mind?
There was a problem hiding this comment.
According to our Develocity statistics, 30 seconds should be enough for all tests. While most of the tests finish in less than 10 seconds, we have some tests taking ~20 seconds to finish.
TBH I thought about a smaller timeout? like 5 seconds, but statistics it won't be enough 😅
So this comment is optional to fix.
osipxd
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.