Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSCrashAdvanced.h is accessible by default #125

Closed
SSheldon opened this issue Feb 27, 2016 · 1 comment
Closed

KSCrashAdvanced.h is accessible by default #125

SSheldon opened this issue Feb 27, 2016 · 1 comment

Comments

@SSheldon
Copy link
Contributor

Starting in 0114ae0, only certain headers of KSCrash/Recording are marked as public. KSCrashAdvanced.h is not one of them. However, with #124, the headers are exposed publicly in the KSCrash/Recording/Advanced subspec, which is installed by default.

A fix here depends on whether or not KSCrashAdvanced.h should be accessible by default:

  • if not, the advanced subspec should not be included by default
  • if so, there's not much reason to have the advanced subspec; the files of it don't compile independently, and since they'll always be exposed they should just be public headers of KSCrash/Recording

I'm assuming the advanced functionality should be "opt-in", and not accessible by default? Pull request incoming.

@SSheldon
Copy link
Contributor Author

Slightly related, if you try to use just the advanced subspec, like:

platform :ios, '8.0'
use_frameworks!

target 'PodsTest' do
  pod 'KSCrash/Recording/Advanced', :git => '[email protected]:kstenerud/KSCrash.git', :tag => '1.0.2'
end

Then you don't actually get the KSCrashAdvanced.h header, since it's not captured by anything's source_files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant