Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven Central #18

Open
bodagetta opened this issue Aug 28, 2015 · 5 comments
Open

Maven Central #18

bodagetta opened this issue Aug 28, 2015 · 5 comments

Comments

@bodagetta
Copy link

Is the Physicaloid Library available from maven central?

@cattaka
Copy link

cattaka commented Dec 8, 2015

I forked to use from maven.
And merge some PRs.

https://github.com/cattaka/PhysicaloidVc

@sureshjoshi
Copy link

Cool! I think you need to update your Apache license to reference the original creator as well, though.

@cattaka
Copy link

cattaka commented Dec 13, 2015

@sureshjoshi
To tell the truth, I'm not understand about Apache License about that well.
If you can. Could you tell me which file I should modify.

@sureshjoshi
Copy link

To be honest, I don't fully understand it either. There is some stuff about Notices, Licenses, modified files, etc...

At the very least, I -think- that you should be including the original copyright in your copyright. As in

Copyright 2015 Takao Sumitomo
Copyright 2013 Keisuke SUZUKI

 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at

   http://www.apache.org/licenses/LICENSE-2.0

 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.

@cattaka
Copy link

cattaka commented Dec 15, 2015

Thank you for your kindness.
I'm going to modify license texts like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants