From 7a801bd30033e5ad884fd66dc077c6cf9ddf0cf3 Mon Sep 17 00:00:00 2001 From: Kshitij Kotasthane Date: Wed, 30 Sep 2020 13:36:53 -0400 Subject: [PATCH] Fix EuiTitle line-height in Amsterdam (#4079) --- CHANGELOG.md | 4 +++- .../eui-amsterdam/global_styling/variables/_typography.scss | 5 +++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 04badd343de..2e93b4397e0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,8 @@ ## [`master`](https://github.com/elastic/eui/tree/master) -No public interface changes since `29.2.0`. +**Theme: Amsterdam** + +- Fixed `line-height` on `EuiTitle` ([#4079](https://github.com/elastic/eui/pull/4079)) ## [`29.2.0`](https://github.com/elastic/eui/tree/v29.2.0) diff --git a/src/themes/eui-amsterdam/global_styling/variables/_typography.scss b/src/themes/eui-amsterdam/global_styling/variables/_typography.scss index 8e9a49ade77..25e01813bf9 100644 --- a/src/themes/eui-amsterdam/global_styling/variables/_typography.scss +++ b/src/themes/eui-amsterdam/global_styling/variables/_typography.scss @@ -14,6 +14,11 @@ $euiFontSizeL: ceil($euiFontSize * 1.57); // 22px // h3 $euiFontSizeXL: floor($euiFontSize * 1.93); // 27px // h2 $euiFontSizeXXL: floor($euiFontSize * 2.43); // 34px // h1 +// Use 8px increments for base gridline +@function lineHeightFromBaseline($multiplier: 3) { + @return convertToRem(($euiSize/2)*$multiplier); +} + $euiTitles: ( 'xxxs': ( 'font-size': $euiFontSizeXS,