Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Optimize festival date lookup in LoadingEmojiManager #579

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 29, 2025

Inverted festival date mapping to allow multiple dates per festival and added logging to track emoji selection.

Bug Fix: The dates were overriden as festival was key in map. So only last day of festival was being matched. Now, unique dates will be the key and festival will be the value.

the emoji was getting overrideen and only one date was selected. now the dates can be multiple
Copy link
Owner Author

ksharma-xyz commented Jan 29, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title Bug Fix emoji dates the emoji was getting overrideen and only one date was selected. now the dates can be multiple UI: Optimize festival date lookup in LoadingEmojiManager Jan 29, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 29, 2025 00:56
Copy link
Owner Author

ksharma-xyz commented Jan 29, 2025

Merge activity

  • Jan 28, 7:56 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 28, 8:09 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz merged commit 7fd6bbe into main Jan 29, 2025
4 checks passed
@ksharma-xyz ksharma-xyz deleted the 01-29-bug_fix_emoji_dates_the_emoji_was_getting_overrideen_and_only_one_date_was_selected._now_the_dates_can_be_multiple branch January 29, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant