UI: Optimize festival date lookup in LoadingEmojiManager #579
+69
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the emoji was getting overrideen and only one date was selected. now the dates can be multiple
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ksharma-xyz
changed the title
Merged
ksharma-xyz
deleted the
01-29-bug_fix_emoji_dates_the_emoji_was_getting_overrideen_and_only_one_date_was_selected._now_the_dates_can_be_multiple
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inverted festival date mapping to allow multiple dates per festival and added logging to track emoji selection.
Bug Fix: The dates were overriden as festival was key in map. So only last day of festival was being matched. Now, unique dates will be the key and festival will be the value.