Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppInfo: Hide build version in release builds for iOS #570

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 26, 2025

TL;DR

Modified iOS version string format to only show build version in debug builds

What changed?

Updated the version string formatting in IOSAppInfo to conditionally display the build version number in parentheses only when running in debug mode. Release builds will now only show the short version.

How to test?

  1. Run the app in debug mode and verify version shows as "1.0.0 (123)"
  2. Run the app in release mode and verify version shows as "1.0.0"

Why make this change?

Build version numbers are primarily useful during development and debugging but add unnecessary complexity to the version string shown to end users in production builds. This change simplifies the version display for regular users while maintaining detailed version information for debugging purposes.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
jeff-mccoy Megamind
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title Display build version for debug builds only AppInfo: Hide build version in release builds Jan 26, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 26, 2025 00:01
Copy link
Owner Author

ksharma-xyz commented Jan 26, 2025

Merge activity

  • Jan 25, 7:01 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 25, 7:11 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz added this to the v1.0.8 milestone Jan 26, 2025
@ksharma-xyz ksharma-xyz added the iOS iOS Target label Jan 26, 2025
@ksharma-xyz ksharma-xyz changed the title AppInfo: Hide build version in release builds AppInfo: Hide build version in release builds for iOS Jan 26, 2025
@ksharma-xyz ksharma-xyz merged commit 96772c6 into main Jan 26, 2025
4 checks passed
@ksharma-xyz ksharma-xyz deleted the 01-24-display_build_version_for_debug_builds_only branch January 26, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS Target
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant