-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mint support? #1038
Comments
By any chance are you using Mint to run Sourcery? Facing same issue |
yep using mint Unfortunately we don't use cocoapods anymore. And Homebrew doesn't allow for you to download specific versions of apps. So mint is really our only option until swift package build tools are supported. |
We've got the same issue using the cocoapods version (updated) |
I know that it's not the best solution but I downgraded the version to 1.0.2 using Mint and it works with Xcode 13.3 |
Mint is not supported because we need stable rPath @kvacquier you got linker issue with dylib with cocoapods? Do you have logs? That shouldn't happen |
I use Sourcery via Mint and it works perfect. But the current issue is the usage of the wrong SwiftSyntax version. For Xcode 13.3 Apple has released a new version. See here: https://github.com/apple/swift-syntax/releases/tag/0.50600.1. Also look to this PR #1037. |
The Sourcery binary produced using If I understand correctly, updating Sourcery to support parsing of Swift 5.6 syntax in files (which would require using the newer SwiftSyntax library) is slightly different to this issue of which version of the Swift toolchain should be used to build the project |
That being said, since the patch in #1037 avoids spm/mint from linking to the lib_internalSwiftSyntaxParser.dylib located in the toolchain of the version of Xcode that you use to build the binary, you could actually build $ mint run liamnichols/Sourcery@bddbeb5 |
@liamnichols That's right, but |
Yeah, I'm not 100% sure here but my understanding of that table is that the "Xcode Release" column is just describing with version of Xcode ships with the default toolchain for that version of Swift and since we can still build SwiftSyntax It would be great to use SwiftSyntax I'll drop some notes based on ☝️ in my PR |
Sorry, to clarify actually because I was kind of wrong.. The version of Xcode Release in the table is important when you rely on it to link to the correct version of lib_InternalSwiftSyntaxParser.dylib which is located at Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx/lib_InternalSwiftSyntaxParser.dylib. If you used Xcode 13.3 to But in the case of #1037, that does not happen/is not a problem because instead we use a separate version of the library that is linked statically |
the problem with Mint is simply the fact it skips my manual re-write of rPath and as such doesn't use the lib version I bundled with the binary in normal Cocoapods / Brew releases, it looks at your Xcode version which can be incompatibile. Static linking will fix all of it |
fixed on main by #1037 |
I get a long list of these errors:
The text was updated successfully, but these errors were encountered: