Continue list and correct node type #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paigerube14
requested review from
chaitanyaenr,
tsebastiani and
shahsahil264
tsebastiani
requested changes
Nov 29, 2023
tsebastiani
previously approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cerberus I had introduced the ability to chunk the requests and be able to continue getting results if there are more than the chunk size (this helps with large scale clusters)
There are a lot of changes here so I want to be sure that the updates are all tested appropriately. I have tested for cerberus, will test within krkn as well
I also noticed that the node type is unknown always so I updated that: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-redhat-chaos-krkn-hub-main-rosa-4.14-nightly-ocp-qe-perfscale-ci-tests-rosa/1729545735780700160