Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Strikethrough #14

Open
AriTheElk opened this issue May 11, 2016 · 2 comments
Open

Proposal: Strikethrough #14

AriTheElk opened this issue May 11, 2016 · 2 comments

Comments

@AriTheElk
Copy link

So I'm in the process of implementing a few features into markingbird and I wanted to run some implementations by you before opening up a pull request.

I've added strikethrough processing alongside bold and italics processing. Should I rename the current "boldItalic..." functions (like escapeBoldItalic()) to escapeBoldItalicStrike()? It seems unnecessary to add an additional function, when typically strikethrough should be processed at the same level as bold and italicized characters.

The other solution I see, is possibly moving to a more generic naming scheme, so that the function names wouldn't have to change with new additions. But perhaps its better to limit this function group to just bold, italic, and strikethrough.

@kristopherjohnson
Copy link
Owner

As strikethrough is not part of John Gruber's original Markdown spec (see http://daringfireball.net/linked/2015/11/05/markdown-strikethrough-slack), I would prefer that it be added as a separate function, and that it be enableable/disableable via MarkdownOptions.

@AriTheElk
Copy link
Author

Ah I see. In that case maybe I'm better off making a github flavored fork of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants