You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So I'm in the process of implementing a few features into markingbird and I wanted to run some implementations by you before opening up a pull request.
I've added strikethrough processing alongside bold and italics processing. Should I rename the current "boldItalic..." functions (like escapeBoldItalic()) to escapeBoldItalicStrike()? It seems unnecessary to add an additional function, when typically strikethrough should be processed at the same level as bold and italicized characters.
The other solution I see, is possibly moving to a more generic naming scheme, so that the function names wouldn't have to change with new additions. But perhaps its better to limit this function group to just bold, italic, and strikethrough.
The text was updated successfully, but these errors were encountered:
So I'm in the process of implementing a few features into markingbird and I wanted to run some implementations by you before opening up a pull request.
I've added strikethrough processing alongside bold and italics processing. Should I rename the current "boldItalic..." functions (like
escapeBoldItalic()
) toescapeBoldItalicStrike()
? It seems unnecessary to add an additional function, when typically strikethrough should be processed at the same level as bold and italicized characters.The other solution I see, is possibly moving to a more generic naming scheme, so that the function names wouldn't have to change with new additions. But perhaps its better to limit this function group to just bold, italic, and strikethrough.
The text was updated successfully, but these errors were encountered: