-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark as deprecated on npm? #866
Comments
It’s a good idea and would be a worthwhile experiment to see whether it makes a difference. I suspect that the projects that continue to rely on Q are in a deep maintenance mode and would not be moved by warnings. And, deprecation is only really meaningful if it suggests that a project is likely to break if they adopt the next major version. I might be more inclined to deprecate q@^1 if I were planning to introduce a q@^2. It’s not impossible that I would find a use for q@^2. I will continue to mull this idea. |
(The reason I would consider making a q@^2 is that native Promises do not support handled-promises or eventual-send https://github.com/endojs/endo/tree/master/packages/eventual-send) |
That is possible. All I can see is usage statistics that tie |
@jsumners-nr the best thing you can do to reduce adoption is probably opening PRs for big packages that have Q as a dependency with a change migrating to native promises |
There are over 10,000 direct dependencies of |
It occurs to me that this is probably my one big chance to say something nice to a lot of people. |
@kriskowal deprecation warnings definitely aren't just used for an upcoming major; if a project is effectively sunset, or even if it just won't get further support, a deprecation message is quite appropriate. |
Beautiful! Thank you very much for taking the time to consider this and act upon it. |
@kriskowal Excuse me, after q marked as deprecated on npm. When I install on nodejs 14 version. It will broken. Can you recover the download version list. |
Check the box right above that that says “show deprecated versions”. Nothing’s broken by deprecating. |
@ljharb Thanks, But it will be error when npm install on nodejs 14. |
And this is a deep dependency,q -->coa -->svgo-->...postcss....-->vue-cli-service@4. I commit a isssue to coa, but the repo is too old and the author not reply. |
@lgzhang the error isn't because the package is deprecated, it's because you're using an old and unsupported version of npm. node 14 is also many years EOL, so you should be upgrading that too. |
@ljharb Thanks,It's unfortunate that nodejs 14 is currently being used in the production environment and upgrading is not that easy, it requires approval from the company. |
@kriskowal would you be up for marking this package as deprecated on npm? I am able to see significant usage persisting today despite the notice in the readme and the lack of maintenance/releases over a long period of time. I believe this is due to no visible notice when the package is installed.
The text was updated successfully, but these errors were encountered: