-
-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Been thinking about removing Tokenization #355
Comments
What do you mean by "filters" exactly? Just looking through the fzf documentation and don't see that exact terminology used. Do you mean the enhanced search syntax, such as Honestly, I don't find myself using the |
Yes, I mean "enhanced search syntax". Couldn't think of a word for it 😄
Agreed.
Interesting feature! |
@krisk I am possibly one of the few people using tokenization but I find it very useful, especially in conjunction with tags. |
@ralf57 - makes sense. I do wonder whether for the tags use-case you could solve it by having the tags as an array in the list though: const list = [{
name: "something"
tags: ["tag1", "tag2", "tag3"]
}]
let fuse = new Fuse(list, {
key: ["tags"]
}) |
@krisk I have a very similar data structure, with tags as simple array, and tokenization really makes a difference with multiple words queries. |
I'm perfectly happy to see tokenization go by the wayside. I think it results in a lot of not so helpful hits when used in conjunction with fuzzy search. OTOH having a way to search things like arrays of tags with tokenization while at the same time searching 'content' fields (regular text) with fuzzy search would be 'nice to have'. Not a priority though. |
@cshoredaniel yes I think I’ll annihilate it. One good thing is that you could still search individual tokens via the use of extended searching. I think it’s much more powerful and produces better results. Its one disadvantage is that the search query may not be too intuitive to an everyday user. |
I've been thinking of removing the tokenization option, mainly because (1) it makes searching and the setup a little counter-intuitive, (2) tokenization could be done by preprocessing the list, and (3) I'm working on adding the ability to use filters, like in fzf, which could possibly make this redundant.
But before I even think about that, I'd love to learn more from the users:
Thanks!
The text was updated successfully, but these errors were encountered: