From 01a4bccb176373f845ed2deab343e2d15b05a59d Mon Sep 17 00:00:00 2001 From: Mikhail Krinkin Date: Thu, 7 Nov 2024 17:44:08 +0000 Subject: [PATCH] [contrib] Stop building ICU tools to fix gcc Envoy build Clang and gcc are subtly different and it seems to be the cause of contrib build failures reported in https://github.com/envoyproxy/envoy/issues/31807 (e.g., when using gcc to link the final binary it results in a bunch of essential for gcc C++ symbols like __gxx_personality_v0). This issue could be addressed (i.e., Envoy can be built using gcc). However, given that it only happens when we build ICU binary tools and those tools aren't used by Envoy directly or the build system, we can just not build them and address the issue this way. Signed-off-by: Mikhail Krinkin --- bazel/foreign_cc/BUILD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bazel/foreign_cc/BUILD b/bazel/foreign_cc/BUILD index 60271a492559..772058a3b6ad 100644 --- a/bazel/foreign_cc/BUILD +++ b/bazel/foreign_cc/BUILD @@ -184,7 +184,6 @@ configure_make( configure_options = [ "--enable-option-checking", "--enable-static", - "--enable-tools", "--disable-draft", "--disable-dyload", "--disable-extras", @@ -193,6 +192,7 @@ configure_make( "--disable-samples", "--disable-shared", "--disable-tests", + "--disable-tools", "--with-data-packaging=static", ], data = ["@com_github_unicode_org_icu//:all"],