Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to terraform-plugin-sdk2 #4

Closed
mavogel opened this issue Nov 29, 2020 · 9 comments · Fixed by #102
Closed

feat: update to terraform-plugin-sdk2 #4

mavogel opened this issue Nov 29, 2020 · 9 comments · Fixed by #102
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mavogel
Copy link
Contributor

mavogel commented Nov 29, 2020

@mavogel mavogel added this to the v2.10.0 milestone Dec 25, 2020
@mavogel
Copy link
Contributor Author

mavogel commented Dec 26, 2020

Currently, trying to fix

tf-sdk-migrator v2upgrade --sdk-version v2.4.0
Rewriting provider go.mod file...
Rewriting SDK package imports...
Running `go mod tidy`...
Error running go mod tidy: exit status 1
go: github.com/hashicorp/terraform-plugin-sdk/[email protected] requires
        cloud.google.com/[email protected] requires
        github.com/google/martian/[email protected] requires
        golang.org/x/[email protected]/go.mod: verifying module: golang.org/x/[email protected]/go.mod: cannot authenticate record data in server response

@innovate-invent, did you have something similar in #23 ?

@mavogel mavogel linked a pull request Dec 26, 2020 that will close this issue
@innovate-invent
Copy link
Contributor

I did not, it looks like the hash of the module is not matching what it is expecting.
I should point out that in my PR I have many manual changes that are required for the update.

@mavogel
Copy link
Contributor Author

mavogel commented Dec 26, 2020

Ok thanks for the heads-up. Do you need any support on the PR from my side @innovate-invent ? I'd like to push this one forward :)

@innovate-invent
Copy link
Contributor

Do you mind taking over the PR? It looks like the original repo and yours have diverged a bit

@mavogel
Copy link
Contributor Author

mavogel commented Dec 26, 2020

Sure thing. Thanks for the initial work. First I need to get the issue mentioned above to be fixed

@innovate-invent
Copy link
Contributor

try and delete the go.sum file?

@mavogel
Copy link
Contributor Author

mavogel commented Dec 27, 2020

tried deleting go.sum, but it did not help 😕

  • I had a similar issue with golang.org/x/oauth2 which I could solve with go get golang.org/x/[email protected], but for golang.org/x/net it does not work...
  • I also tried export GOPROXY=https://gocenter.io,https://proxy.golang.org,direct, which did not help either

@innovate-invent
Copy link
Contributor

innovate-invent commented Dec 27, 2020

perhaps add

replace github.com/google/martian/[email protected] => github.com/google/martian/[email protected]

to your go.mod?

also try go clean -modcache if you haven't already

@mavogel
Copy link
Contributor Author

mavogel commented Dec 27, 2020

go clean -modcache was the key :) Thx. Feels like I need to dig a bit deeper into those modules to understand the process.
Now I can continue at least.

@mavogel mavogel self-assigned this Dec 27, 2020
@mavogel mavogel removed a link to a pull request Dec 27, 2020
@mavogel mavogel linked a pull request Dec 27, 2020 that will close this issue
7 tasks
@mavogel mavogel added the enhancement New feature or request label Dec 27, 2020
@mavogel mavogel removed this from the v2.10.0 milestone Jan 7, 2021
@mavogel mavogel added this to the v2.12.0 milestone May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants