Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issues #5

Open
AndyLnd opened this issue Jun 19, 2014 · 2 comments
Open

Security issues #5

AndyLnd opened this issue Jun 19, 2014 · 2 comments

Comments

@AndyLnd
Copy link

AndyLnd commented Jun 19, 2014

I am not sure whether this a bug or a feature. When you start the server, you can easily access your console from any computer in the network. You simply have to change the host value in Yez.js on the client.
You could probably avoid this by using a white/blacklist on the server to limit the access or you could employ a password based authentication.

Cheers!

@krasimir
Copy link
Owner

That's a very good point. Here is how I'm planning to solve the problem:

  1. The Node.js module yez will accept a string. Like for example yez mypassword. The string will be the password for access.
  2. If there is a password then the client (i.e. the dev tools extension will ask for credentials).

Following this approach we will protect the Node.js executable and at the same time will provide backward compatibility. What you think?

@AndyLnd
Copy link
Author

AndyLnd commented Jun 20, 2014

That would work and keep the option to connect to your machine remotely. You would have to add the possibility to change the target ip on the client more conveniently, of course.
There is one problem in this scenario, though: the password will be transmitted unsecured in your current setup. So maybe it would make sense to combine the two approaches, or to consider using a SSL connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants