Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have a switch for zero exit code when tests fail #59

Closed
zzhengjian opened this issue Mar 5, 2019 · 4 comments
Closed

Can we have a switch for zero exit code when tests fail #59

zzhengjian opened this issue Mar 5, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@zzhengjian
Copy link

Can we have a switch for non-zero exit code for failing tests? This cause the jenkins job failing, and actually for me, I only need to view tests run info in the automation report, so I want the jenkins job is always successful.

@zzhengjian
Copy link
Author

When you have e2e test cases, it's quite normal to have failed tests due to many reasons, so compare to unit test, we may need to be more tolerate for this.

@zzhengjian zzhengjian changed the title Can we have a switch for non-zero exit code when tests fail Can we have a switch for zero exit code when tests fail Mar 5, 2019
@grawk
Copy link
Member

grawk commented Mar 11, 2019

Hi @zzhengjian that makes sense. I'm not sure when I can get to it. If someone can contribute a PR it might be quicker.

@grawk grawk added enhancement New feature or request help wanted Extra attention is needed labels Mar 11, 2019
@zzhengjian
Copy link
Author

@grawk Hi, I create a PR #64, please take a review.

@grawk
Copy link
Member

grawk commented Oct 9, 2019

closed by #64

@grawk grawk closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants