Skip to content
This repository was archived by the owner on Jan 31, 2025. It is now read-only.

Make sure this.nemo available in all mocha lifecycle functions #19

Closed
grawk opened this issue May 22, 2018 · 1 comment · Fixed by #20
Closed

Make sure this.nemo available in all mocha lifecycle functions #19

grawk opened this issue May 22, 2018 · 1 comment · Fixed by #20
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@grawk
Copy link
Member

grawk commented May 22, 2018

Currently this.nemo is available in the test (it) context and the beforeEach context. Make the nemo object available in all mocha lifecycle functions:
before
beforeEach
after
afterEach
@grawk grawk added enhancement New feature or request help wanted Extra attention is needed labels May 22, 2018
@nikulkarni
Copy link
Collaborator

Hey so I looked at the code and currently this.nemo is available in beforeEach, afterEach and after. Its only not available in before. Ideally nemo should be a brand new object for every test and it shouldn't be shared across tests. Therefore I am not sure if we should set it up in before, currently its set correctly in beforeEach. Do we have a use case that I'm missing where its needed in before?

@grawk grawk mentioned this issue Jun 8, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add nemo to mocha lifecycle context so its available to before/after/… krakenjs/nemo
2 participants
@grawk @nikulkarni