Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code generation instead of calling Signature.build_request? #144

Open
eigenein opened this issue Nov 14, 2024 · 0 comments
Open

Use code generation instead of calling Signature.build_request? #144

eigenein opened this issue Nov 14, 2024 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@eigenein
Copy link
Member

Currently, each backend is forced to call Signature.build_request for every call:

request = signature.build_request(Request, self, args, kwargs)

I'm wondering if instead it could generate a «request builder», which would be generated once and contain calls to all the markers. The same applies to apply_response_markers:

return signature.apply_response_markers(response, payload, response_type)

@eigenein eigenein added enhancement New feature or request question Further information is requested labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant