Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'oldlines' of undefined #49

Closed
nwtn opened this issue Mar 1, 2015 · 5 comments
Closed

Cannot read property 'oldlines' of undefined #49

nwtn opened this issue Mar 1, 2015 · 5 comments

Comments

@nwtn
Copy link

nwtn commented Mar 1, 2015

I'm getting this error when using jsdiff via grunt-patch. I've posted the issue with details on the grunt-patch repo (nettantra/grunt-patch#3), but the error appears to be coming from jsdiff, so I thought I'd post it here as well. Any ideas what may be causing this issue?

@kpdecker
Copy link
Owner

kpdecker commented Mar 2, 2015

I think the best thing would be to try to setup a jsfiddle or similar demonstrating the issue, that or open a PR with a failing test case. Issues with repo cases are always fixed faster :)

@sebastian-zarzycki
Copy link

I have the same problem.

@kpdecker
Copy link
Owner

If an example showing how to reproduce this isn't posted then it will never be fixed.

@sebastian-zarzycki
Copy link

It chokes on pretty much everything unified. I believe it's because it expects index header or particular number of lines. My diff file started with this and it couldn't parse it

--- angular-translate-loader-static-files.js
+++ angular-translate-loader-static-files.js
@@ -42,7 +42,7 @@

When removed first two lines:

@@ -42,7 +42,7 @@

it worked.

When added two lines:

Index: angular-translate-loader-static-files.js
===================================================================
--- angular-translate-loader-static-files.js
+++ angular-translate-loader-static-files.js
@@ -42,7 +42,7 @@

it worked.

@kpdecker
Copy link
Owner

Released in 1.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants