From f6b718161a73f1efad5551edbc35d7c14f3a127a Mon Sep 17 00:00:00 2001 From: Jeppe Reinhold Date: Fri, 6 Dec 2024 11:03:14 +0100 Subject: [PATCH 1/2] force install dependencies to ignore peer dep warnings --- scripts/bench/bench-packages.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/bench/bench-packages.ts b/scripts/bench/bench-packages.ts index 1651f5507301..e7dd22ff1a87 100644 --- a/scripts/bench/bench-packages.ts +++ b/scripts/bench/bench-packages.ts @@ -92,10 +92,10 @@ export const benchPackage = async (packageName: PackageName) => { 2 ) ); - const npmInstallResult = await x( 'npm', - `install --registry http://localhost:6001 --omit peer --json`.split(' '), + // --force to ignore peer dependency warnings, we aren't installing peer dependencies anyway + `install --registry http://localhost:6001 --omit peer --json --force`.split(' '), { nodeOptions: { cwd: tmpBenchPackagePath }, } From 32c8e435ea88c5517acc47c8ee4d1a9de7243fb3 Mon Sep 17 00:00:00 2001 From: Yann Braga Date: Fri, 6 Dec 2024 13:11:24 +0100 Subject: [PATCH 2/2] Temporarily disable CRA sandboxes --- .circleci/config.yml | 36 +++++++++---------- .../cli-storybook/src/sandbox-templates.ts | 8 ++--- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 550dc9e6b994..e124f267f1ba 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -836,27 +836,27 @@ workflows: requires: - unit-tests - create-sandboxes: - parallelism: 14 + parallelism: 13 requires: - build - build-sandboxes: - parallelism: 14 + parallelism: 13 requires: - create-sandboxes - chromatic-sandboxes: - parallelism: 11 + parallelism: 10 requires: - build-sandboxes - e2e-production: - parallelism: 9 + parallelism: 8 requires: - build-sandboxes - e2e-dev: - parallelism: 2 + parallelism: 1 requires: - create-sandboxes - test-runner-production: - parallelism: 9 + parallelism: 8 requires: - build-sandboxes - vitest-integration: @@ -912,27 +912,27 @@ workflows: requires: - unit-tests - create-sandboxes: - parallelism: 20 + parallelism: 19 requires: - build - build-sandboxes: - parallelism: 20 + parallelism: 19 requires: - create-sandboxes - chromatic-sandboxes: - parallelism: 17 + parallelism: 16 requires: - build-sandboxes - e2e-production: - parallelism: 15 + parallelism: 14 requires: - build-sandboxes - e2e-dev: - parallelism: 2 + parallelism: 1 requires: - create-sandboxes - test-runner-production: - parallelism: 15 + parallelism: 14 requires: - build-sandboxes - vitest-integration: @@ -986,30 +986,30 @@ workflows: requires: - build - create-sandboxes: - parallelism: 38 + parallelism: 36 requires: - build # - smoke-test-sandboxes: # disabled for now # requires: # - create-sandboxes - build-sandboxes: - parallelism: 38 + parallelism: 36 requires: - create-sandboxes - chromatic-sandboxes: - parallelism: 35 + parallelism: 33 requires: - build-sandboxes - e2e-production: - parallelism: 33 + parallelism: 31 requires: - build-sandboxes - e2e-dev: - parallelism: 2 + parallelism: 1 requires: - create-sandboxes - test-runner-production: - parallelism: 33 + parallelism: 31 requires: - build-sandboxes - vitest-integration: diff --git a/code/lib/cli-storybook/src/sandbox-templates.ts b/code/lib/cli-storybook/src/sandbox-templates.ts index fe89f9decae0..f905d2841803 100644 --- a/code/lib/cli-storybook/src/sandbox-templates.ts +++ b/code/lib/cli-storybook/src/sandbox-templates.ts @@ -172,7 +172,6 @@ const baseTemplates = { extraDependencies: ['server-only', 'prop-types'], }, skipTasks: ['e2e-tests-dev', 'bench', 'vitest-integration'], - inDevelopment: true, }, 'nextjs/default-ts': { name: 'Next.js Latest (Webpack | TypeScript)', @@ -229,7 +228,6 @@ const baseTemplates = { 'prop-types', ], }, - inDevelopment: true, skipTasks: ['e2e-tests-dev', 'bench'], }, 'experimental-nextjs-vite/default-ts': { @@ -806,7 +804,8 @@ export const allTemplates: Record = { }; export const normal: TemplateKey[] = [ - 'cra/default-ts', + // TODO: Add this back once we resolve the React 19 issues + // 'cra/default-ts', 'react-vite/default-ts', 'angular-cli/default-ts', 'vue3-vite/default-ts', @@ -836,7 +835,8 @@ export const merged: TemplateKey[] = [ export const daily: TemplateKey[] = [ ...merged, 'angular-cli/prerelease', - 'cra/default-js', + // TODO: Add this back once we resolve the React 19 issues + // 'cra/default-js', 'react-vite/default-js', 'react-vite/prerelease-ts', 'react-webpack/prerelease-ts',