You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there, we (Rust group @sslab-gatech) are scanning crates on crates.io for potential soundness bugs. We noticed that the Retro struct which allows for some unsafe operations is marked as #[doc(hidden)]:
However, this still allows one to import this struct in and potentially use it to trigger unsafe operations from safe Rust code. Instead, maybe this struct should be pub(crate) to actually restrict it's usage?
The text was updated successfully, but these errors were encountered:
Hi there, we (Rust group @sslab-gatech) are scanning crates on crates.io for potential soundness bugs. We noticed that the
Retro
struct which allows for some unsafe operations is marked as#[doc(hidden)]
:libretro-backend/src/lib.rs
Lines 208 to 209 in 9248d74
However, this still allows one to import this struct in and potentially use it to trigger unsafe operations from safe Rust code. Instead, maybe this struct should be
pub(crate)
to actually restrict it's usage?The text was updated successfully, but these errors were encountered: