Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Core struct as pub(crate) instead of [doc(hidden)] #17

Open
ammaraskar opened this issue Feb 5, 2021 · 0 comments
Open

Mark Core struct as pub(crate) instead of [doc(hidden)] #17

ammaraskar opened this issue Feb 5, 2021 · 0 comments

Comments

@ammaraskar
Copy link

Hi there, we (Rust group @sslab-gatech) are scanning crates on crates.io for potential soundness bugs. We noticed that the Retro struct which allows for some unsafe operations is marked as #[doc(hidden)]:

libretro-backend/src/lib.rs

Lines 208 to 209 in 9248d74

#[doc(hidden)]
pub struct Retro< B: Core > {

However, this still allows one to import this struct in and potentially use it to trigger unsafe operations from safe Rust code. Instead, maybe this struct should be pub(crate) to actually restrict it's usage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant