Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-mode indentation is not very consistent #68

Open
rye opened this issue Jul 30, 2017 · 5 comments
Open

Web-mode indentation is not very consistent #68

rye opened this issue Jul 30, 2017 · 5 comments

Comments

@rye
Copy link
Member

rye commented Jul 30, 2017

It seems that we have not set up tracking on this to make variable values consistent. Nor have we set up SQL support, which is part of web-mode.

Since web development is such a big part of my life, it's a damn shame that I haven't fixed this to this point.

@rye
Copy link
Member Author

rye commented Jul 30, 2017

web-mode seems to have a web-mode-use-tabs function@cg505, how does that look? If possible, we could just add that to the web-mode-hook that we already have, or advise it or something.

@cg505
Copy link
Contributor

cg505 commented Jul 31, 2017

we have not set up tracking on this to make variable values consistent.

What does this mean?

web-mode seems to have a web-mode-use-tabs function—@cg505, how does that look

Seems fine, but we need to make sure editorconfig is respected.

@rye
Copy link
Member Author

rye commented Jul 31, 2017

Tracking = kotct/setf-tabs or whatever the function that sets the variable and updates it when the global value is updated.

@rye
Copy link
Member Author

rye commented Jul 31, 2017

And I'll look into editor config support. I'm pretty sure that changes variables downstream and would fix any misconfiguration by the global thing.

@cg505
Copy link
Contributor

cg505 commented Jul 31, 2017

Got it. Kinda forgot that was a thing.

@rye rye modified the milestone: Version 0.2.0 Aug 3, 2017
@rye rye modified the milestones: Version 0.2.0, Version 0.3.0 Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants