Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ktor 3 compatibility #454

Closed
stashymane opened this issue Apr 24, 2024 · 8 comments · Fixed by #459
Closed

Ktor 3 compatibility #454

stashymane opened this issue Apr 24, 2024 · 8 comments · Fixed by #459

Comments

@stashymane
Copy link

I have attempted to port Kodein to Ktor 3 myself, as only two changes were required, however one test is failing: https://github.com/stashymane/Kodein/commit/89a4d60fd72ecd24d4e0cd5c2caad05660559413

image

It seems that the call pipeline is being skipped for some reason. Otherwise the update is rather simple.
Here's the run for details: https://github.com/stashymane/Kodein/actions/runs/8818984587/job/24209096046

@ssmtlbn
Copy link

ssmtlbn commented Oct 17, 2024

Since Ktor 3 is now final, is there an update on when or if it will be supported?

@Burtan
Copy link

Burtan commented Oct 26, 2024

I get errors with kodein 7.22.0 and ktor 3.0.0

Found interface io.ktor.server.routing.Routing, but class was expected
java.lang.IncompatibleClassChangeError: Found interface io.ktor.server.routing.Routing, but class was expected
	at org.kodein.di.ktor.ClosestKt.closestDI$lambda$2(closest.kt:32)

@Burtan
Copy link

Burtan commented Dec 3, 2024

I still get the same errors:

Found interface io.ktor.server.routing.Routing, but class was expected
java.lang.IncompatibleClassChangeError: Found interface io.ktor.server.routing.Routing, but class was expected
	at org.kodein.di.ktor.ClosestKt.closestDI$lambda$2(closest.kt:32)

Do you need anything?

@romainbsl
Copy link
Member

romainbsl commented Dec 3, 2024

Ktor 3 Compatibility has not been released in a stable release.

You can try it on the snapshot channel.
maven repository: https://s01.oss.sonatype.org/content/repositories/snapshots
target version of Kodein: 7.24.0-main-SNAPSHOT

Will release soon. Probable next week.

@Burtan
Copy link

Burtan commented Dec 3, 2024

Ah, thanks, I somehow thought it was part of 7.23.1. Sorry!

@jvlka-jvlka
Copy link

@romainbsl, any news about stable version compatible with ktor 3.0.+ ?

@romainbsl
Copy link
Member

It is available on SNAPSHOT, and it will probably come as is. I plan to work on Ktor plugin registry and compose related features before releasing a new version.

In the meantime, you can use it from the snapshot channel.
maven repository: https://s01.oss.sonatype.org/content/repositories/snapshots
target version of Kodein: 7.24.0-main-SNAPSHOT

@jvlka-jvlka
Copy link

jvlka-jvlka commented Jan 7, 2025

Thanks for responding. In my company we are allow to use only stable versions. We ASAP need to upgrade ktor to 3.0.0. @romainbsl , did you have chance to work on new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants