Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with backporting after a branch has been deleted #90

Closed
Atemu opened this issue Jul 7, 2021 · 2 comments · Fixed by #162
Closed

Possible issue with backporting after a branch has been deleted #90

Atemu opened this issue Jul 7, 2021 · 2 comments · Fixed by #162
Labels
bug Something isn't working

Comments

@Atemu
Copy link

Atemu commented Jul 7, 2021

This may just have happened in NixOS/nixpkgs#129258.

I deleted the branch, noticed that it should be backported and added the label. Since that didn't immediately work, I restored the branch and re-applied the label.

This could just be an error of impatience on my end but I wanted to make sure.

I'm not well versed enough in JS to figure out how exactly the ref to be backported is fetched here but if you're fetching the source branch from the fork, perhaps look into fetching refs/pull/$num/head on the source repo itself instead.

@korthout
Copy link
Owner

korthout commented Jul 7, 2021

Hi @Atemu, thanks for sharing this ❤️

Deletion of the branch is definitely a problem of the current approach. I've also been thinking about how to deal with #46 and fetching refs/pull/$num/head might be the solution for both issues. However, that requires a larger change which I've been postponing a bit, but I really want to get started on. I have some ideas and I know how to validate these, but it takes time. Fixing these will push the action out of early-development and into version 0.1.x range IMO.

I hope to spend time on this soon.

@korthout
Copy link
Owner

korthout commented Oct 6, 2021

@Atemu Problem should be resolved with the latest master. I'll probably release a new version soon as well, but please be aware that you can already try this fix by using master or 3359d57. With #162 it is now also no longer necessary to set fetch-depth: 0 for the actions/checkout@v2 action.

EDIT: I've released v0.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants