Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release latest version onto crates.io? #15

Open
wyager opened this issue Dec 22, 2024 · 5 comments
Open

Release latest version onto crates.io? #15

wyager opened this issue Dec 22, 2024 · 5 comments

Comments

@wyager
Copy link

wyager commented Dec 22, 2024

I forked this library with the intention of making the types use num_traits, but it looks like this has already been done on git, and just not released yet. Any intention of releasing a new version with the latest changes?

@korken89
Copy link
Owner

Alright, I can make a release 👍

@korken89
Copy link
Owner

Released on crates.io 🎉

@wyager
Copy link
Author

wyager commented Dec 26, 2024

Constructing filters like this:

DirectForm2Transposed::<f32>::new(
                Coefficients::<f32>::from_params(
                    biquad::Type::BandPass,
                    sample_rate.hz(),
                    freq.hz(),
                    50.,
                )
                .unwrap(),
            )

It looks like bumping from 0.4.x -> 0.5.0 shifts the frequency response of my filters by a factor of ~4 (perhaps exactly 4) - is that expected?

@korken89
Copy link
Owner

That's not expected. Unfortunately I do not have time to look into the issue, could you have a look at the diff to see if you see something weird?

@korken89 korken89 reopened this Dec 26, 2024
@wyager
Copy link
Author

wyager commented Dec 27, 2024

Yeah, I will dig into this soon-ish. Maybe a *2 and /2 got swapped or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants