-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dev login #195
Merged
Merged
feat: add dev login #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonmasberg
force-pushed
the
chore/test-oauth
branch
5 times, most recently
from
May 9, 2023 22:05
1a0ae84
to
4c3f20f
Compare
timonmasberg
force-pushed
the
chore/test-oauth
branch
from
May 11, 2023 11:02
72f5eb9
to
5cc2993
Compare
JSPRH
previously approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing!
timonmasberg
force-pushed
the
chore/test-oauth
branch
from
May 15, 2023 10:23
14dc804
to
5848891
Compare
JSPRH
approved these changes
May 16, 2023
Kudos, SonarCloud Quality Gate passed! |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a Dev Authentication Module in our SPA that developers can use to simply create tokens and setup a user session with preset or custom claims. The Dev Authentication Module will also be used in CI-E2Es, so it is not necessary anymore to have actual Azure AD users in development environments. It is still possible to add Test Users as an Environment variable and serve the API with an OAuth Configuration, as we continue to do for Next Deployment E2Es to validate the correct implementation of Azure Active Directory B2C as OAuth Provider.
This is how the Dev login process locks like:
Screen.Recording.2023-05-09.at.17.58.13.mov
Furthermore, it adds a dev-tokens.md file to the API application, that contains token for our test users to use them directly to authenticate with the API.
Resolves #131