Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: version metadata is empty when the tag is non empty? #1112

Closed
HarikrishnanBalagopal opened this issue Dec 8, 2023 · 2 comments · Fixed by #1128
Closed

bug: version metadata is empty when the tag is non empty? #1112

HarikrishnanBalagopal opened this issue Dec 8, 2023 · 2 comments · Fixed by #1128

Comments

@HarikrishnanBalagopal
Copy link
Contributor

https://github.com/konveyor/move2kube/blame/e88ceceee7e8e76a587827d9555035566d4d0b38/Makefile#L58
@HarikrishnanBalagopal HarikrishnanBalagopal changed the title bug: version metadata is wrong? bug: version metadata is empty when the tag is non empty? Dec 8, 2023
@akagami-harsh
Copy link
Contributor

@HarikrishnanBalagopal , can you please give some more information about the issue

@HarikrishnanBalagopal
Copy link
Contributor Author

HarikrishnanBalagopal commented Jan 5, 2024 •
edited
Loading

@HarikrishnanBalagopal , can you please give some more information about the issue

cc: @ashokponkumar The VERSION_METADATA was added a long time ago

https://github.com/konveyor/move2kube/blame/e88ceceee7e8e76a587827d9555035566d4d0b38/Makefile#L56-L59

VERSION_METADATA = unreleased
ifneq ($(GIT_TAG),)
	VERSION_METADATA =
endif

not sure if this is really a bug?
Few options instead of leaving it empty:

  • VERSION_METADATA = released
  • VERSION_METADATA = prerelease and VERSION_METADATA = stable depending on the git tag/version

@akagami-harsh akagami-harsh mentioned this issue Jan 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Move2Kube
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add condition for version_metadata in Makefile akagami-harsh/move2kube
2 participants
@HarikrishnanBalagopal @akagami-harsh