Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use podman as runtime to build and execute the UI #97

Closed
rmarting opened this issue Sep 28, 2021 · 3 comments · Fixed by #98
Closed

Use podman as runtime to build and execute the UI #97

rmarting opened this issue Sep 28, 2021 · 3 comments · Fixed by #98

Comments

@rmarting
Copy link
Contributor

Is your feature request related to a problem? Please describe.

docker is currently supported to build and run locally UI, however in development environments podman or buildah are the tools used to build and run containers.

If you don't have docker the build process fails with:

❯ make cbuild
docker build -t quay.io/konveyor/move2kube-ui-builder:latest --cache-from quay.io/konveyor/move2kube-ui-builder:latest --target build_base                             --build-arg VERSION=latest .
make: docker: No such file or directory
make: *** [Makefile:73: cbuild] Error 127

Describe the solution you'd like

Allow to build and run locally this tool using other container runtimes, such as podman.

Describe alternatives you've considered

Additional context

This feature will allow to increase the number of users/developers of this tool.

@HarikrishnanBalagopal
Copy link
Contributor

@rmarting
Copy link
Contributor Author

@HarikrishnanBalagopal it could help that using an alias, but IMHO the Makefile should cover both container technologies if we want to demostrate the value of other container runtimes such as podman.

Replacing docker references in the Makefile file to podman the build works successfully. Now it is not running because it is affected by the issue reported here.

Maybe the solution could add some container runtime check at the begining of the Makefile to avoid the developer has to use alias or change the development station to build and compile this tool. Again this mi opinion, and maybe I am wrong, and the tool has to force to use docker to build and run.

WDYT?

@rmarting
Copy link
Contributor Author

@HarikrishnanBalagopal I am not an expert developer in Makefile files, however I created this PR #98 as an approach of my idea to use docker or podman to build and run the tool. I hope this PR could help to improve this User Experience.

Open to modify or adapt the file with the rules or recomendations you could suggest me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants