Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retry #2311

Merged
merged 4 commits into from
Oct 23, 2024
Merged

fix: retry #2311

merged 4 commits into from
Oct 23, 2024

Conversation

CristhianF7
Copy link
Contributor

@CristhianF7 CristhianF7 commented Oct 23, 2024 •
edited
Loading

Description

  • Handles secret creation error properly secrets "container-registry-auth" already exists
  • Added execution control for post-detokenize process

patrickdappollonio
patrickdappollonio requested changes Oct 23, 2024
View reviewed changes
cmd/k3d/create.go Outdated Show resolved Hide resolved
internal/gitShim/containerRegistryAuth.go Outdated Show resolved Hide resolved
@CristhianF7 CristhianF7 merged commit 439685c into main Oct 23, 2024
8 checks passed
@CristhianF7 CristhianF7 deleted the fix-retry branch October 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokestax jokestax jokestax approved these changes

@patrickdappollonio patrickdappollonio patrickdappollonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CristhianF7 @patrickdappollonio @jokestax