Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api convention #1795

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Api convention #1795

merged 4 commits into from
Sep 1, 2023

Conversation

johndietz
Copy link
Contributor

No description provided.

@konstructio konstructio deleted a comment from gitguardian bot Sep 1, 2023
cmd/civo/create.go Outdated Show resolved Hide resolved
Co-authored-by: Jared Edwards <[email protected]>
@gitguardian
Copy link

gitguardian bot commented Sep 1, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7973515 Elliptic Curve Private Key daeac81 kubefirst-kubeconfig View secret
7973515 Elliptic Curve Private Key bb9a866 kubefirst-kubeconfig View secret
7973516 Generic High Entropy Secret daeac81 kubefirst-kubeconfig View secret
7973516 Generic High Entropy Secret bb9a866 kubefirst-kubeconfig View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

jarededwards
jarededwards previously approved these changes Sep 1, 2023
@johndietz johndietz merged commit afd7b03 into main Sep 1, 2023
2 of 3 checks passed
@johndietz johndietz deleted the api-convention branch September 1, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants