Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditorConfig support to Console #2239

Closed
Tracked by #2235
mrsimonemms opened this issue Jul 10, 2024 · 4 comments · Fixed by konstructio/console#481
Closed
Tracked by #2235

Add EditorConfig support to Console #2239

mrsimonemms opened this issue Jul 10, 2024 · 4 comments · Fixed by konstructio/console#481

Comments

@mrsimonemms
Copy link
Contributor

mrsimonemms commented Jul 10, 2024

This exists to standardise IDE configuration automatically and reduce compatibility issues across operating systems etc. See parent issue for more details

@CristhianF7
Copy link
Contributor

Thanks @mrsimonemms. I think this is good for our golang repositories but Console has their own configuration with linter and prettier and this may cause a lot of issues.

@mrsimonemms
Copy link
Contributor Author

@CristhianF7 Prettier and EditorConfig solve related, but distinct problems. Prettier makes sure the JavaScript is formatted to a known format, EditorConfig covers all files. It also covers things like line-endings, which Prettier/ESLint tend not to cover in my experience.

I've used Prettier/ESLint and EditorConfig together for about 10 years and never had a problem so I think this would be useful to include.

@CristhianF7
Copy link
Contributor

Thanks for confirming @mrsimonemms

@mrsimonemms
Copy link
Contributor Author

No probs. There's a PR for this which would like a review when you have time konstructio/console#481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants