Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make azure dns resource group optional #839

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Dec 2, 2024

Description

Updated the 2.7 docs too

Related Issue(s)

Fixes konstructio/kubefirst#2342

How to test

@mrsimonemms mrsimonemms marked this pull request as ready for review December 2, 2024 09:18
@mrsimonemms mrsimonemms force-pushed the sje/azure-optional-dns branch from 4d9bd33 to 43101b6 Compare December 2, 2024 09:20
@mrsimonemms mrsimonemms force-pushed the sje/azure-optional-dns branch from f453cd5 to c684c29 Compare December 2, 2024 14:10
Copy link
Contributor

@konstructcarrie konstructcarrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrsimonemms mrsimonemms merged commit 724ac1d into main Dec 2, 2024
13 checks passed
@mrsimonemms mrsimonemms deleted the sje/azure-optional-dns branch December 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs with optional Azure DNS group
2 participants