Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnc-prebuild-git-clone: add build team to owners #1962

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chmeliik
Copy link
Contributor

The task is generated from the git-clone task => changes to the git-clone task will always require corresponding changes to the PNC task.

Add build team to the CODEOWNERS of this task to avoid git-clone changes being blocked on reviews from the PNC team.

Also move this task to the same Renovate group as git-clone. Otherwise Renovate PRs would fail CI because they would only update the git-clone task and not the PNC task.

The task is generated from the git-clone task => changes to the
git-clone task will always require corresponding changes to the PNC
task.

Add build team to the CODEOWNERS of this task to avoid git-clone changes
being blocked on reviews from the PNC team.

Also move this task to the same Renovate group as git-clone. Otherwise
Renovate PRs would fail CI because they would only update the git-clone
task and not the PNC task.

Signed-off-by: Adam Cmiel <[email protected]>
@chmeliik
Copy link
Contributor Author

Would solve the failure in #1932

But a better solution would be to rework the pnc prebuild task. @rnc why is it generated from git-clone? Would it work for the pnc prepare stuff to be a standalone task? clone -> pnc-prebuild -> build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant