Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent merge conflicts with crate-hashes directory #82

Open
kolloch opened this issue Jan 31, 2020 · 0 comments
Open

Prevent merge conflicts with crate-hashes directory #82

kolloch opened this issue Jan 31, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@kolloch
Copy link
Collaborator

kolloch commented Jan 31, 2020

Currently, we cache hashes of prefetched packages (= crates) in crate-hashes.json. This is basically a simple list of package name / hash which can lead to many merge conflicts if dependencies keep changing.

If we saved the hashes in individual files in a crate-hashes directory, we would avoid this problem. crate2nix could search for existing hashes in all files and then write the still needed ones into a new file. It can then delete all the old files. This is easily mergeable. You might end up temporarily with multiple files but it will always converge to few or one file.

Currently, we also do NOT save any hash sums that we obtained from the lock file. For people who are not checking in lock files, this might be contraproductive. There is no real downside to saving all hashes.

@kolloch kolloch added this to the 0.8 milestone Feb 10, 2020
@kolloch kolloch modified the milestones: 0.8, 0.9 Mar 29, 2020
@kolloch kolloch added the enhancement New feature or request label Mar 29, 2020
@kolloch kolloch removed this from the 0.9 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant