Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention about original lib #7

Closed
jrybinski opened this issue Feb 14, 2020 · 3 comments
Closed

Mention about original lib #7

jrybinski opened this issue Feb 14, 2020 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@jrybinski
Copy link

Hey @kolkov.
First of all.
Great job with this one! 🤝 🍻

I didn't find anything in README about a package which was I think your inspiration.
https://github.com/lukasz-galka/ngx-gallery
I think it's almost a copy of this project with an update to the new angular version.
I think it's worth to mention the original author and give some credits for him.

I know that the original package is probably abandoned but still most of the works have been done by him.

@kolkov
Copy link
Owner

kolkov commented Feb 14, 2020

Yes, it will be necessary to add this, as long as it is only in the original package in the issues section.

@obenjiro
Copy link

obenjiro commented Feb 26, 2020

@kolkov I also want to add:

  1. You actually violating MIT license by removing original author from LICENSE.md and not giving original author any credit.

MIT License have only one important rule "The MIT license requires that "the above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."

You can write this in LICENSE.md

Copyright (c) 2017 Your Name
Copyright (c) 2015-2016 Previous Developer's Name
Copyright (c) 2014-2016 Other Project Developer's Name

Or you can have your own LICENCE.md with only your name but you should include original MIT license to every file that was forked (put it on top of file)

  1. Attributing previous author is a nice thing to do :) I know that you would also wanted that your work to be credited and mentioned.

PS: thanks a lot for you work on this project 👍

@kolkov
Copy link
Owner

kolkov commented Mar 1, 2020

@obenjiro thanks for the detailed comment. I will add this info in next update.

@kolkov kolkov added the documentation Improvements or additions to documentation label Mar 1, 2020
@kolkov kolkov closed this as completed in af546f6 Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants