Adding converting constructor in Kokkos::RandomAccessIterator #6929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtrott
reviewed
Apr 11, 2024
algorithms/src/std_algorithms/impl/Kokkos_RandomAccessIterator.hpp
Outdated
Show resolved
Hide resolved
fnrizzi
reviewed
Apr 12, 2024
dalg24
reviewed
Apr 12, 2024
algorithms/src/std_algorithms/impl/Kokkos_RandomAccessIterator.hpp
Outdated
Show resolved
Hide resolved
| ASSERT_TRUE(first_st2first_d); | ||
| ASSERT_TRUE(first_st2first_s); | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe add a comment that it would be good to have a test for the explicit specifier with an expression.
I just looked over the View converting constructors and they are all implicit so I don't see what we can actually do at the moment.
There was a problem hiding this comment.
Thanks for your comments. I fixed accordingly.
I am less confident in the final point about a comment.
If something is wrong, please let me know
masterleinad
approved these changes
Apr 15, 2024
…od idea because it let user write code that would compile with C++17 but not with later standards.
dalg24
approved these changes
Apr 15, 2024
|
One of the CUDA build timed out (unrelated) |
|
@yasahi-hpc please add an entry to the changelog for this PR |
This was referenced Apr 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at adding a missing converting constructor in
Kokkos::RandomAccessIterator.Convertibility of iterators is based on the convertibility of underlying views.
It now allows to construct
a non-const iterator from a const iterator but disallows to construct a const iterator from a non-const iteratora const iterator from a non-const iterator but disallows to construct a non-const iterator from a const iterator