SIMD: convert binary operators to hidden friends #6320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far... |
ldh4
force-pushed
the
simd_binary_ops_to_hidden_friends
branch
from
e371fee to
4f907cc
Compare
dalg24
reviewed
Aug 11, 2023
simd/src/Kokkos_SIMD_Scalar.hpp
Outdated
| simd const& lhs, simd const& rhs) noexcept { | ||
| return simd(lhs.m_value >> static_cast<int>(rhs[0])); | ||
| return simd(lhs.m_value >> static_cast<value_type>(rhs)); |
There was a problem hiding this comment.
Why are we casting to value_type rather than using rhs.value directly?
There was a problem hiding this comment.
Replaced to use rhs.m_value instead. 787c301
| KOKKOS_IMPL_HOST_FORCEINLINE_FUNCTION mask_type | ||
| operator<(simd const& other) const { | ||
| return mask_type(_mm256_cmp_pd(m_value, other.m_value, _CMP_LT_OS)); | ||
| [[nodiscard]] KOKKOS_IMPL_HOST_FORCEINLINE_FUNCTION simd operator-() const |
There was a problem hiding this comment.
It's because these intrinsic functions are not constexpr.
Placing constexpr specifier will produce errors: call to non-'constexpr' function '__m256d _mm256_sub_pd.
ldh4
force-pushed
the
simd_binary_ops_to_hidden_friends
branch
from
ccff122 to
bce57b1
Compare
ldh4
force-pushed
the
simd_binary_ops_to_hidden_friends
branch
from
bce57b1 to
787c301
Compare
|
Retest this please. |
nliber
approved these changes
Aug 23, 2023
dalg24
approved these changes
Aug 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #6109 (comment).
Converted binary operators to hidden friends and modified operator signatures to stay consistent with class overview provided in P1928R6.