Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile.kokkos Can Have Issues with Compiler Selection #556

Closed
nmhamster opened this issue Dec 1, 2016 · 2 comments
Closed

Makefile.kokkos Can Have Issues with Compiler Selection #556

nmhamster opened this issue Dec 1, 2016 · 2 comments

Comments

@nmhamster
Copy link
Contributor

We have an potential issue with the compiler selection. The ifeq ($(KOKKOS_INTERNAL_COMPILER_XL), 1) can be an issue if the version outputs additional text (e.g. the XL Beta compiler). This should really be a greater than check rather than an equals.
@nmhamster nmhamster added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Dec 1, 2016
@crtrott
Copy link
Member

crtrott commented Dec 1, 2016

yeah I know I fixed that internally already.

@crtrott crtrott added duplicate and removed Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) labels Dec 1, 2016
@crtrott
Copy link
Member

crtrott commented Dec 1, 2016

Duplicate of #553 so I close this again.

@crtrott crtrott closed this as completed Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nmhamster @crtrott