Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jstype = JS_STRING #19

Closed
joticajulian opened this issue Sep 6, 2021 · 0 comments · Fixed by #23
Closed

Add jstype = JS_STRING #19

joticajulian opened this issue Sep 6, 2021 · 0 comments · Fixed by #23
Assignees
Labels

Comments

@joticajulian
Copy link
Contributor

Javascript has an issue with uint64. They can not be treated as "number" because the max safe integer in javascript is 2^53 - 1.
https://chromium.googlesource.com/chromium/src/third_party/+/refs/heads/main/protobuf/js/binary/decoder.js?autodive=0%2F%2F#540

I found this issue in the protobuf repo: protocolbuffers/protobuf#3666 (comment) they recommend to use

message dummy { uint64 bigInt = 1; [jstype = JS_STRING] }
@mvandeberg mvandeberg transferred this issue from koinos/koinos-proto-js Sep 7, 2021
@sgerbino sgerbino added the task label Sep 13, 2021
@youkaicountry youkaicountry self-assigned this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants