Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window floats after exiting fullscreen video #619

Closed
ahan98 opened this issue Jul 21, 2020 · 1 comment
Closed

Window floats after exiting fullscreen video #619

ahan98 opened this issue Jul 21, 2020 · 1 comment

Comments

@ahan98
Copy link

ahan98 commented Jul 21, 2020

Hi, first time posting an issue, so sorry if I'm doing something against etiquette.

This issue is minor, but has some interesting side effects. I have only noticed it through the following reproduction:

  1. Begin with a bsp layout
  2. Open up a YouTube video (I used Google Chrome, but browser shouldn't matter)
  3. Press f to fullscreen the video, moving it to a new space
  4. Press f to exit out of fullscreen, exiting the space

Now the window is floating (although, strangely, if you run yabai -m query --windows, the window of that video will output "floating":0) and the borders are gone (to fix this issue, the windows would need to be re-managed back to bsp). Another interesting effect is that if you exit the video by closing the space with a skhd hotkey, or by using esc, rather than f, to exit the video, no issues occur.

Link to gif (sorry for the low quality)

In the screencast, I first reproduce the issue by pressing f to exit fullscreen and show that layout has been changed to float. Then, after re-managing the windows back to bsp, I exit fullscreen by pressing esc to show the non-problematic behavior.

In the screencast, we can see that when f is used to exit the video, the layout for only that window changes to float (the other window is still bsp). Next, though this was hard to see in the gif, the border for only that window disappears as well. But when using esc, neither of these two issues occur, and layout/border behavior works as expected.

Note that my .yabairc is basically empty/stock.

What I tried: Added to .yabairc a function to set layout to bsp and borders on when signaled by space_changed, but I couldn't get that to work.

Thanks!

@koekeishiya
Copy link
Owner

Sounds like a duplicate of #586, you can confirm this by opening some other application/window on the same space that your browser initially on, before you make the video fullscreen.

@ahan98 ahan98 closed this as completed Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants