-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependency eslint-config-kodefox to v0.2.1 #351
base: master
Are you sure you want to change the base?
Conversation
9cbdab0
to
5bc38b2
Compare
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. If you think this comment is in error and the branch is not modified, try deleting this comment. If it comes back again the next time Renovate runs, please submit an issue or seek config help. |
I wonder if the import rule is an overkill if we also specify the order of parent and current dir imports, maybe we just care about the order of the import from packages and from our files. Especially when this is a lint rule, prettier formatting wont fix it when saving. (We could run eslint --fix, but it's one extra step) /cc @kodefox/infra |
4406484
to
9f1551b
Compare
9f1551b
to
f575d88
Compare
Actually, I don't mind about that as it could force us for better readability. But instead of grouping based on the path parenthesis, I wish it would group the import based on I'll take a look at the library and see if I could change the grouping preference. /cc @kodefox/infra |
Here is how my proposal looks like #400. |
a96a930
to
7a2380f
Compare
Hey @darcien, shall we land this one? |
Good idea! I'll try to update that one first. |
I think our conclusion from #400 is to skip the So I'm sure we could land this one. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
^0.2.2
->^0.3.0
0.1.0
->0.3.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.