Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuxt-speedkit try two #7806

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Nuxt-speedkit try two #7806

merged 4 commits into from
Oct 24, 2023

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented Oct 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Copilot Summary

🤖 Generated by Copilot at 90af573

Added nuxt-speedkit module to improve website performance. Updated package.json file with the new dependency.

🤖 Generated by Copilot at 90af573

nuxt-speedkit added
to boost the Nuxt gallery
winter wind is swift

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3a7be2a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6537dffe406a9300087669a0
😎 Deploy Preview https://deploy-preview-7806--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added the large Pull request is large label Oct 24, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 24, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 24, 2023

AI-Generated Summary: This pull request includes the modification of package.json to add a new package dependency. Specifically, the nuxt-speedkit package was added with version 3.0.0-next.27.

@yangwao yangwao marked this pull request as ready for review October 24, 2023 15:03
@yangwao yangwao requested a review from a team as a code owner October 24, 2023 15:03
@yangwao yangwao requested review from preschian and floyd-li and removed request for a team October 24, 2023 15:03
@yangwao
Copy link
Member Author

yangwao commented Oct 24, 2023

Yes, the module is not in nuxt.config.ts, yet it improves numbers. 10pts for performance, cut in half for other metrics.

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 24, 2023

Code Climate has analyzed commit 3a7be2a and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member Author

yangwao commented Oct 24, 2023

Continue to

I think it's an improvement due @nuxt/image ?
image

@yangwao yangwao merged commit f37792c into main Oct 24, 2023
13 of 14 checks passed
@yangwao yangwao deleted the nuxtspeedkit-trytwo branch October 24, 2023 15:43
@roiLeo
Copy link
Contributor

roiLeo commented Oct 25, 2023

sad noises 😞

Capture d’écran 2023-10-25 à 4 48 27 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants