Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(BasicBalanceInput): to compositionApi #6877

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

stephenjason89
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 769abca

Refactored the code for opening the shopping cart modal from the navbar. Moved the logic and configuration from ShoppingCartModalConfig.ts and ShoppingCartButton.vue to Navbar.vue to improve code organization and performance.

🤖 Generated by Copilot at 769abca

ShoppingCartButton
Simpler, no more emit -
Autumn leaves falling

@stephenjason89 stephenjason89 requested a review from a team as a code owner August 22, 2023 14:47
@stephenjason89 stephenjason89 requested review from vikiival and daiagi and removed request for a team August 22, 2023 14:47
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 66c8889
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e4ca8139cbe70008dba4b3
😎 Deploy Preview https://deploy-preview-6877--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 22, 2023

AI-Generated Summary: This pull request includes a refactoring of the BasicBalanceInput component in order to use Vue's Composition API. It replaces the nuxt-property-decorator package with the Vue's composition API functions such as defineProps, defineEmits, and computed. It also replaces @prop decorators with the use of defineProps, the @ref and @emit with ref and defineEmits, respectively. The changes simplify the code, making it more readable and maintainable. Overall, this patch improves the efficiency and clean coding of the BasicBalanceInput component, making use of the more modern composition API in Vue.js.

@codeclimate
Copy link

codeclimate bot commented Aug 22, 2023

Code Climate has analyzed commit 66c8889 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Aug 22, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 22, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephenjason89 stephenjason89 mentioned this pull request Aug 22, 2023
1 task
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 22, 2023
@yangwao
Copy link
Member

yangwao commented Aug 23, 2023

pay 50 usd

@yangwao yangwao merged commit 31b9102 into kodadot:main Aug 23, 2023
10 of 11 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 23, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.42 USD/DOT ~ 11.312 $DOT
🧗 16UcV9V6nVvPYdHz98ymUKmNLkzjCEU5sbKJMi7hxYyTHjzR
🔗 0xf7e9a7c2080749e4dc80b3b8e468170edc004ed22d3965848ce2c3b6c313fe19

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 23, 2023
@stephenjason89
Copy link
Contributor Author

@yangwao thank you ♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants