Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SearchSortDropDown): to compositonApi #6804

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

stephenjason89
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 769abca

Refactored the code for opening the shopping cart modal from the navbar. Moved the logic and configuration from ShoppingCartModalConfig.ts and ShoppingCartButton.vue to Navbar.vue to improve code organization and performance.

🤖 Generated by Copilot at 769abca

ShoppingCartButton
Simpler, no more emit -
Autumn leaves falling

@stephenjason89 stephenjason89 requested a review from a team as a code owner August 19, 2023 01:55
@stephenjason89 stephenjason89 requested review from preschian and daiagi and removed request for a team August 19, 2023 01:55
@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 964d49e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e021176af7a30008db939c
😎 Deploy Preview https://deploy-preview-6804--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 19, 2023

AI-Generated Summary: This pull request contains refactoring of the SearchSortDropdown component in Vue.js. The refactoring includes a transition from the Options API to the Composition API which enables better reusability and readability. Key changes include removal of the prefixMixin, migration of the component's properties to the defineProps function, and replacement of the class-based component with setup. emit is now utilized for event emission. The use of computed properties has been introduced for selectedAction, isMoonriver, actions, and sort. Overall, these changes will enhance the maintainability and scalability of the code.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 19, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 19, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Aug 19, 2023

Code Climate has analyzed commit 964d49e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VueUse for selectedAction?
Otherwise lgtm

@yangwao
Copy link
Member

yangwao commented Aug 19, 2023

pay 50 usd
faster selectors

@yangwao yangwao merged commit 7734e1b into kodadot:main Aug 19, 2023
11 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 19, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.49 USD/DOT ~ 11.136 $DOT
🧗 16UcV9V6nVvPYdHz98ymUKmNLkzjCEU5sbKJMi7hxYyTHjzR
🔗 0x82edd4eabe76915cd859ddd62395371f4d228162e8d11207c0b4501f6fae9689

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants