Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove-nuxt-property-decorator-#2 #6452

Merged
merged 8 commits into from
Jul 21, 2023
Merged

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Jul 21, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Pages in this PR

  1. massmint
  2. massmint/onboarding
  3. bsx/assets
  4. bsx/claim
  5. bsx/incomingOffers
  6. bsx/offers
  7. bsx/stats
  8. bsx/waifu
  9. rmrk/mint

desired outcome

no change in look and/or behavior

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 9850182

Refactored several components in the pages directory to use default export and dynamic import syntax, and removed unused or unnecessary code. This improved the code consistency, readability, maintainability, and performance across the project.

🤖 Generated by Copilot at 9850182

We're refactoring our components, me hearties, yo ho ho
We're using default export and dynamic import, yo ho ho
We're removing unused code and decorators, yo ho ho
We're improving our performance and readability, yo ho ho

@daiagi daiagi requested a review from a team as a code owner July 21, 2023 10:33
@daiagi daiagi requested review from roiLeo and Jarsen136 and removed request for a team July 21, 2023 10:33
@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9850182
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ba5efeaebc080009b8d4cd
😎 Deploy Preview https://deploy-preview-6452--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 21, 2023

AI-Generated Summary: This pull request contains several changes across multiple Vue.js files. It removes usage of the Vue component decorator, refactoring components to use the default export pattern. Consequently, the component declarations are less verbose and more readable.

  1. Pages under the _prefix/massmint directory have been updated to include middleware functionality to handle redirection, and they utilize the 'usePreferencesStore' for preferences.

  2. Updates have been made to the bsx pages (bsx/assets.vue, bsx/claim.vue, bsx/incomingOffers.vue, bsx/offers.vue, bsx/stats.vue, and bsx/waifu.vue) to modify the component declarations. Each file now exports a default component with a defined name and dynamically imported components.

  3. The rmrk/mint.vue file has seen similar changes, with the SimpleMint component now being imported dynamically.

All these changes contribute to improving code readability and organization, as well as leverages better Vue.js patterns and practices for component definition.

@codeclimate
Copy link

codeclimate bot commented Jul 21, 2023

Code Climate has analyzed commit 9850182 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Jul 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 21, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jul 21, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@vikiival vikiival merged commit b5d7657 into main Jul 21, 2023
@vikiival vikiival deleted the remove-nuxt-property-decorator-#2 branch July 21, 2023 12:05
@vikiival
Copy link
Member

bulk one

@vikiival
Copy link
Member

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Jul 21, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 5.48 USD/DOT ~ 5.474 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0xa3175c0243d27bed38a997df19a5f069e6e4db78d98af24a7b8443990a2ffc58

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jul 21, 2023
This was referenced Jul 25, 2023
This was referenced Jul 28, 2023
This was referenced Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants