Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce-using-nuxt-proprty-decorator/Teleport-page #6451

Merged
merged 5 commits into from
Jul 21, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Jul 21, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Pages in this PR

  1. 🔥 delete unused teleport page /teleport
  2. /spotlight

desired outcome

no change in look and/or behavior

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

🤖 Generated by Copilot at 69c85fe

This pull request introduces a new feature to allow token transfers between different chains using the Teleport.vue component. It also adds a block explorer URL to the useChain composable, refactors the Spotlight.vue page component, and updates the English translation file.

🤖 Generated by Copilot at 69c85fe

Teleport.vue lets
tokens cross chains with Polkadot
a winter feature

@daiagi daiagi requested a review from a team as a code owner July 21, 2023 09:46
@daiagi daiagi requested review from preschian and vikiival and removed request for a team July 21, 2023 09:46
@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f34fd9b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ba554e13fd360008e1fa13
😎 Deploy Preview https://deploy-preview-6451--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 21, 2023

AI-Generated Summary: This pull request includes creation of a new Teleport.vue component file to refactor the transfer.vue component, in order to better modularize the application. It brings many changes such as introduction of computed properties for features like hasAddress, correctAddress, disabled, and so on. It also includes watchers to synchronize the component's state with route changes, as well as introducting more computed properties currentRoute and routeMessage. Furthermore, the logic for transaction submissions and error handling has been updated. This PR also includes a change to useChain.ts adding the blockExplorer property, and couple of changes in en.json and spotlight.vue files. It removed plenty of code from transfer.vue file, moving it to the new Teleport.vue component.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jul 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 21, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Jul 21, 2023

Code Climate has analyzed commit f34fd9b and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure teleport page isn't used? I made some changes in #6449

@daiagi
Copy link
Contributor Author

daiagi commented Jul 21, 2023

are you sure teleport page isn't used? I made some changes in #6449

mmm are'nt we using prefix/teleport?

  1. that's where the link in the wallet menu points to
  2. teleport page is ugly / looks like something forgot behind
  • prefix/teleport :
    image

  • /teleport
    image

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jul 21, 2023
@vikiival vikiival merged commit 60ed8b5 into main Jul 21, 2023
@vikiival vikiival deleted the reduce-using-nuxt-proprty-decorator/Teleport-page branch July 21, 2023 12:03
This was referenced Jul 25, 2023
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants