Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 migrate b-button part 2 #6449

Merged
merged 9 commits into from
Jul 31, 2023
Merged

🔧 migrate b-button part 2 #6449

merged 9 commits into from
Jul 31, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 21, 2023 •
edited
Loading

part of #5852

  • replaced all b-button
  • removed unused component

@roiLeo roiLeo requested a review from a team as a code owner July 21, 2023 07:33
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team July 21, 2023 07:33
@netlify
Copy link

netlify bot commented Jul 21, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 93ce85b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64c776323803b4000883250d
😎 Deploy Preview https://deploy-preview-6449--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 21, 2023

AI-Generated Summary: This pull request modifies several components mainly related to the Navbar, ConnectWallet, MessageNotify, and Sharing. It does the following:

  1. Updates the tag for the search bar's cancel button to use an "a" element instead of a "b-button" component in Navbar.vue.
  2. Removes the hasSelectedWalletProvider ref and corresponding button in ConnectWalletModal.vue.
  3. Replaces the b-button tags to button in WalletMenuItem.vue.
  4. Replaces the Sharing component in MessageNotify.vue with the ShowQRModal component, adds a computed property realworldFullPath, and useRoute is imported.
  5. Deletes Sharing.vue component altogether.
  6. Makes some styling and alignment adjustments in _connect-wallet.scss.

The second part of the commit makes adjustments in WalletMenuItem.vue, transfer.vue, and teleport.vue. Several changes are mainly related to modifying the b-button Vue.js Bulma component to native button and NeoButton components, adjustments in copy functionalities, and code cleanup.

This pull request aims to enhance the user experience and optimize code structure.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jul 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 21, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

This was referenced Jul 21, 2023
Closed
Merged
@prury
Copy link
Member

prury commented Jul 21, 2023 •
edited
Loading

  • navbar cancel button works
  • QR modal works
  • connect wallet modal and wallet buttons working properly
  • add button finally fixed, ohhh ❤️

image

messy buttons(mobile):

image

i was going to open a issue to add a remove address button, but saw that the transfers page will also suffer a redesign, so.

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 21, 2023
@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jul 21, 2023
daiagi
daiagi approved these changes Jul 22, 2023
View reviewed changes
components/Navbar.vue Outdated Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented Jul 25, 2023

image

👀

@yangwao
Copy link
Member

yangwao commented Jul 28, 2023

@roiLeo let's fix it :)

@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 31, 2023

ooo

@codeclimate
Copy link

codeclimate bot commented Jul 31, 2023

Code Climate has analyzed commit 93ce85b and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo mentioned this pull request Jul 31, 2023
Merged
6 tasks
@vikiival vikiival merged commit 759315a into kodadot:main Jul 31, 2023
This was referenced Aug 2, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daiagi daiagi daiagi approved these changes

@vikiival vikiival vikiival approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
large Pull request is large S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roiLeo @prury @yangwao @vikiival @daiagi