#6223 double stroke issues

[prachi00]

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Needs QA check

• @kodadot/qa-guild please review

Context

• Closes Double stroke visual issue  #6223
• Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

• My DOT address: Payout

Screenshot 📸

• My fix has changed UI

Copilot Summary

[kodabot]

WARNING @prachi00 PR for issue #6223 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6223

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	a97fd31
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64ac603c19ab9900084ab9c2
😎 Deploy Preview	https://deploy-preview-6263--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[reviewpad]

AI-Generated Summary: This pull request addresses the double stroke issues in #6223 by making changes to components/explore/ExploreGrid.vue, components/gallery/GalleryItemActionSlides.vue, components/massmint/Massmint.vue, and components/navbar/CreateDropdown.vue files. It adds a new class "middle-icon" to the grid size button in ExploreGrid.vue, changes border styles to have "!important" in GalleryItemActionSlides.vue and Massmint.vue, and modifies the code structure in CreateDropdown.vue to separate dropdown menu items based on the "chain" value.

[roiLeo]

This look like a hotfix, Imo something wrong with NeoTab scss config

[prachi00]

This look like a hotfix, Imo something wrong with NeoTab scss config

what do you mean wrong?

[prachi00]

@roiLeo does something needs to be changed here?

[roiLeo]

@roiLeo does something needs to be changed here?

I don't really like this solution, we'll always have this problem check profile page buttons for example

[prachi00]

@roiLeo does something needs to be changed here?

I don't really like this solution, we'll always have this problem check profile page buttons for example

I dont think there is any other way to fix it though other than manual css?

[roiLeo]

I dont think there is any other way to fix it though other than manual css?

it should work using default oruga css, check out doc example of field with addons.

[prachi00]

@roiLeo even in oruga fields, there is double border

[roiLeo]

I would try someting different, create a css rule where all element inside a NeoField with addons should have border-right removed but :not(:last-child)

[prury]

@prachi00, i know i said in the issue that some other PR fixed it, but i've checked again and is still happening:

[prachi00]

@prachi00, i know i said in the issue that some other PR fixed it, but i've checked again and is still happening:

which chain is this? I dont see it

[prury]

@prachi00, i know i said in the issue that some other PR fixed it, but i've checked again and is still happening:

which chain is this? I dont see it

RMRK2:
https://deploy-preview-6263--koda-canary.netlify.app/ksm/gallery/18429103-7EA1DCF47E98A25067-3MAX-UNIEDITION_1-00000001

[prachi00]

@prury weird I dont see it, I am on chrome, and you are on chrome too?

[prury]

@prury weird I dont see it, I am on chrome, and you are on chrome too?

I'm on Firefox, you got it, it's a Firefox only issue, tested on Chrome and it won't happen.

[prachi00]

@prury
I cant reproduce this even in firefox

@roiLeo can we merge this one for now? We can create a different issue to track firefox issue
Also, PS giving border left to fields might not work as in some cases we have border bottom as well that is double stroked and in some cases its not the fields but tabs

[roiLeo]

I don't see any difference with beta, why would we merge it?

[prachi00]

in beta there is double stroke

[prachi00]

maybe we can close this pr if its not relevant anymore
@exezbcz @roiLeo

[roiLeo]

For multiple buttons wrapped in NeoField I would see something like:

.o-field--addons > :not(:first-child):not(:last-child) button,
.o-field--addons > button:not(:first-child):not(:last-child) {
  border-right: 0;
  border-left: 0;
}

and I think we can do something similar for MassMint tabs

Why do you have some changes in CreateDropdown component?

[prachi00]

For multiple buttons wrapped in NeoField I would see something like:

.o-field--addons > :not(:first-child):not(:last-child) button,
.o-field--addons > button:not(:first-child):not(:last-child) {
  border-right: 0;
  border-left: 0;
}

and I think we can do something similar for MassMint tabs

Why do you have some changes in CreateDropdown component?

for massmints, cant find a common class as it an <a tag
dropdown changes are gone after resolving conflicts

[roiLeo]

for massmints, cant find a common class as it an <a tag dropdown changes are gone after resolving conflicts

Alright, noted.

code lgtm

[prury]

only double stroke remaining was the one on profile, but let's leave it for profile redesign, works for me.

[prachi00]

can we merge this pls

[codeclimate]

Code Climate has analyzed commit a97fd31 and detected 0 issues on this pull request.

View more on Code Climate.

[vikiival]

pay 13 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $13 @ 5.15 USD/DOT ~ 2.524 $DOT
🧗 13Qx65nLd6SwdtjrRyuoEtp9CKXhF651xdHBPaXcvhwKm4N1
🔗 0x0bc14f00dfadf159899946f804442dd4283186ac4a9703d8326465af8cb55241

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues