Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown overlay legend #6057

Merged
merged 2 commits into from
May 24, 2023
Merged

fix: dropdown overlay legend #6057

merged 2 commits into from
May 24, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented May 21, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at d65a8e1

This pull request enhances the PriceChart component by improving its responsiveness on smaller screens and adding a legend option for point styles. These changes improve the user experience and the visual consistency of the chart.

🤖 Generated by Copilot at d65a8e1

We are the masters of the chart
We shape the legend with our art
We make the data fit the screen
We are the rebels of the PriceChart

@daiagi daiagi requested a review from a team as a code owner May 21, 2023 13:39
@daiagi daiagi requested review from preschian and Jarsen136 and removed request for a team May 21, 2023 13:39
@kodabot
Copy link
Collaborator

kodabot commented May 21, 2023

WARNING @daiagi PR for issue #6037 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6037

@netlify
Copy link

netlify bot commented May 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f3d78a9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646a1fc212d8dd00088a7753
😎 Deploy Preview https://deploy-preview-6057--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 21, 2023

AI-Generated Summary: This pull request includes updates to the PriceChart.vue and _price-chart.scss files. It adds a new legend configuration with usePointStyle: true in the chart options and modifies the dropdown overlay's appearance by adjusting the positioning and adding responsive style rules. The changes result in 13 new lines of code and 1 line deletion across 2 files.

@codeclimate
Copy link

codeclimate bot commented May 21, 2023

Code Climate has analyzed commit f3d78a9 and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 23, 2023
@yangwao
Copy link
Member

yangwao commented May 24, 2023

pay 30 usd

@yangwao yangwao merged commit 4cb267d into main May 24, 2023
@yangwao yangwao deleted the fix/priceChart-dropdown-overlay branch May 24, 2023 10:24
This was referenced May 25, 2023
@daiagi
Copy link
Contributor Author

daiagi commented May 29, 2023

Payout didn't work @yangwao
Note payment address is DOT

@yangwao
Copy link
Member

yangwao commented Aug 4, 2023

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Aug 4, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 5.02 USD/DOT ~ 9.96 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0xe8a005879fea0b2dca9015aa920c6c7c9ec8bca2df406c51252f3ced3f26f86a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overlapping display at chart on mobile
6 participants