Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add prefix to the transfer #5969

Merged
merged 3 commits into from
May 15, 2023
Merged

fix: Add prefix to the transfer #5969

merged 3 commits into from
May 15, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 14, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image

Copilot Summary

🤖 Generated by Copilot at 4d9fa2e

This pull request updates various files related to the payment link and the network prefix for the Kusama chain. It fixes quotation marks, whitespace, and formatting issues in the issue and pull request templates, the README, and the REWARDS files. It also adds a middleware function to redirect /transfer routes to /ksm/transfer and makes the transfer and teleport pages use dynamic network prefixes. These changes improve the consistency, functionality, and user experience of the NFT gallery.

🤖 Generated by Copilot at 4d9fa2e

urlPrefix prop
helps to avoid redirection
cutting through the web

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 14, 2023 16:03
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team May 14, 2023 16:03
@kodabot
Copy link
Collaborator

kodabot commented May 14, 2023

SUCCESS @Jarsen136 PR for issue #5957 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 14, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b2ac926
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646230d18f03a3000840a737
😎 Deploy Preview https://deploy-preview-5969--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 14, 2023

AI-Generated Summary: This pull request includes various changes related to updating URLs and redirect methods related to KodaDot's transfer functionality. Most of the changes involve updating the /transfer path to the new /${urlPrefix}/transfer pattern. This is also applied to issue templates and payment links throughout the codebase. Additionally, a few stylistic and formatting adjustments were made in several files, such as quotes being updated to a consistent style in the ISSUE_TEMPLATE files.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels May 14, 2023
@vikiival
Copy link
Member

vikiival commented May 15, 2023

I found the edge case with is not scope of this PR

Screenshot 2023-05-15 at 12 25 58

@vikiival
Copy link
Member

@Jarsen136 can you please roll back change from " to ' ? Its unrelated to this PR

@vikiival
Copy link
Member

Looks like deployment is failing?

@codeclimate
Copy link

codeclimate bot commented May 15, 2023

Code Climate has analyzed commit b2ac926 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit fc41d4e into kodadot:main May 15, 2023
@vikiival
Copy link
Member

Continue to #5980

@Jarsen136
Copy link
Contributor Author

@Jarsen136 can you please roll back change from " to ' ? Its unrelated to this PR

I'm sorry for that. It's an auto format on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prefix to the transfer
3 participants